From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v9 03/12] telemetry: initial telemetry
	infrastructure
Date: Sat, 27 Oct 2018 04:33:19 +0200
Message-ID: <2084760.x53lBy41Uf@xps>
References: <20181024160311.85457-1-kevin.laatz@intel.com>
 <3436860.VK1RJtmnne@xps>
 <E923DB57A917B54B9182A2E928D00FA65E2FA72C@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, "Laatz,
 Kevin" <kevin.laatz@intel.com>, "Nicolau, Radu" <radu.nicolau@intel.com>,
 "Hunt, David" <david.hunt@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ED54B1B05
 for <dev@dpdk.org>; Sat, 27 Oct 2018 04:33:15 +0200 (CEST)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA65E2FA72C@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/10/2018 04:19, Van Haaren, Harry:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 27/10/2018 01:59, Harry van Haaren:
> > > --- a/mk/rte.vars.mk
> > > +++ b/mk/rte.vars.mk
> > > +JANSSON := $(shell pkg-config --exists jansson; echo $$?)
> > > +ifneq ($(JANSSON),0)
> > > +$(warning Jansson not found, disabling RTE_LIBRTE_TELEMETRY)
> > > +CONFIG_RTE_LIBRTE_TELEMETRY = n
> > > +endif
> > 
> > It fails for cross-compilation.
> > Example:
> > When compiling i686 on x86_64 host, no error with
> > 	pkg-config --exists jansson
> > but fails when linking:
> > 	/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-
> > gnu/8.2.1/../../../libjansson.so when searching for -ljansson
> > 	/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-
> > gnu/8.2.1/../../../libjansson.a when searching for -ljansson
> > 	/usr/bin/ld: skipping incompatible /usr/lib/libjansson.so when searching
> > for -ljansson
> > 	/usr/bin/ld: skipping incompatible /usr/lib/libjansson.a when searching
> > for -ljansson
> > 	/usr/bin/ld: cannot find -ljansson
> > 
> > Note: there is the same issue with examples/vm_power_manager/Makefile
> > 
> > I start thinking it is not reasonnable to enable an optional dependency
> > in our Makefiles. Perhaps the only solution is to use meson...
> 
> Ouch, yes if x86_64 pkg-config finds the available library, and it is not available in its i686 form, or other combinations thereof, things become another-level of complex.

On ArchLinux, I have pkg-config-32 for i686 libs.
And for true cross-compilation with sysroot, some environment variables
are required. See this doc:
	https://autotools.io/pkgconfig/cross-compiling.html

> Indeed Meson is (good | getting better) at detecting these things, Bruce knows more IIRC :)
> 
> @Thomas, for this release I propose to rework to use CONFIG=N as default for Make, and allow packagers to enable if they wish. Is that a good next-step?

Yes it looks reasonnable disabling telemetry by default in make case.