From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/2] new filter APIs definition Date: Tue, 21 Oct 2014 00:04:40 +0200 Message-ID: <2085898.nAXrvty0kN@xps13> References: <1413502161-31403-1-git-send-email-jingjing.wu@intel.com> <1413783633-16222-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jingjing Wu Return-path: In-Reply-To: <1413783633-16222-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-20 13:40, Jingjing Wu: > new filter APIs definition in ethdev > define filter_ctrl ops in i40e driver > > v2 changes: > remove OP from the name of filter opeartions > add API implementation in i40e. > correct comments > > Jingjing Wu (2): > librte_ether: new filter APIs definition > i40e: define filter_ctrl ops in i40e driver As Bruce suggested, RTE_ETH_FILTER_NOP is simpler than RTE_ETH_FILTER_OP_NONE. And I think RTE_ETH_FILTER_GET_INFO could be RTE_ETH_FILTER_INFO. Last comment: filtering features (fdir, hash) should not be defined at this stage. I know that we want this patch integrated with high priority, so I made the above changes by myself. Hope you'll agree. Acked-by: Thomas Monjalon Applied Thank you for your patience -- Thomas