From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] test: fix missing NULL pointer checks Date: Thu, 18 Dec 2014 22:05:34 +0100 Message-ID: <20867625.qP6gkIlEQ3@xps13> References: <1418895707-468-1-git-send-email-danielx.t.mrzyglod@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Daniel Mrzyglod Return-path: In-Reply-To: <1418895707-468-1-git-send-email-danielx.t.mrzyglod-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-18 09:41, Daniel Mrzyglod: > In test_sched, we are missing NULL pointer checks after calls to create the > mempool and to allocate an mbuf. Add in these checks using VERIFY macros. > > Signed-off-by: Daniel Mrzyglod > --- > app/test/test_sched.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test/test_sched.c b/app/test/test_sched.c > index c957d80..9b6e037 100644 > --- a/app/test/test_sched.c > +++ b/app/test/test_sched.c > @@ -166,6 +166,7 @@ test_sched(void) > int err; > > mp = create_mempool(); > + VERIFY(mp != NULL,"Error create mempool\n"); A space is missing after the comma. Is "Error creating mempool" more correct? > port_param.socket = 0; > port_param.rate = (uint64_t) 10000 * 1000 * 1000 / 8; > @@ -184,6 +185,7 @@ test_sched(void) > > for (i = 0; i < 10; i++) { > in_mbufs[i] = rte_pktmbuf_alloc(mp); > + VERIFY(in_mbufs[i] != NULL, "Bad packet allocation"); An \n is missing. "Packet allocation failed" seems more appropriate. -- Thomas