From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] igb_ethdev.c: complete switches for i211 NC Date: Wed, 24 Sep 2014 19:38:29 +0200 Message-ID: <2088737.Lh69b6AKpB@xps13> References: <1409819711-18718-1-git-send-email-grrwlf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Sergey Mironov Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-09-10 01:28, Zhang, Helin: > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Sergey Mironov > > Hi! I have got an update for my "i212 problem". First of all, I found that I have > > made a mistake. My controller is named i211, not i212 :) Next, i211 controller is > > controlled by the lib_pmd_e1000 driver. > > Unfortunately, looks like it's support is pure. For example, igb_ethdev.c > > contains function eth_igb_infos_get() which should set number of tx/rx queues > > supported by the hardware. It contains huge [switch] but there is no i211 case! > > That is why I see zeros every time I try to start this NC. Also, there are few > > other places which mention i210, but not mention i211. I've attached a patch > > which adds necessary > > i211 support, but I didn't check it enough to say it is totally correct. For now I > > see that it just able to send and receive some packets. > > > > Could you please review/correct it? The funny thing is that the file igb_rxtx.c seems to already support i211, but not igb_ethdev.c. Thanks for fixing that. > > if ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) || > > - (hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) { > > + (hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) || > > + (hw->mac.type == e1000_i211)) { Wrong indent here. > Reviewed-by: Helin Zhang > > Really good to have this patch of supporting i211! Thank you very much! Acked and applied with indent fix. Thanks -- Thomas