From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF1FC35DF5 for ; Tue, 25 Feb 2020 09:47:09 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6E472218AC for ; Tue, 25 Feb 2020 09:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="mCqatmt6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="yQZw/JqK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E472218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A610A1BFCD; Tue, 25 Feb 2020 10:46:59 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id ED6321BFC7 for ; Tue, 25 Feb 2020 10:46:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A6D937DA; Tue, 25 Feb 2020 04:46:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 25 Feb 2020 04:46:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CCi+TRNs4t0DUph8K84vn7/Ryhu66ywld3dQLR5Fo5Q=; b=mCqatmt6QOxz fvuOoxLdnncpFBWSJyYw45CcZwO50N6k/z48UK6dorRQx/fq1rEZe0dPdJGBC9mr yUonXMVhpj/av1BwiW6PDHEhSadaq//PqSMk7uhsTK8FlBvJRIGPz7AjqN5E+lWk pcrAhoVvl+Jq5POWd9JaVzn7RndWgI8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CCi+TRNs4t0DUph8K84vn7/Ryhu66ywld3dQLR5Fo 5Q=; b=yQZw/JqKlNUVzyeTHOF9ldYn68/uT6PmAM1hvXjNc/P+1BwtROw02rht3 tENdLd/lZEe5RTELeTZyxxvS33PCUdITLnte6k3CBB4kPCXHALwQyuIMw13Wqa7i KbNNMQmoX/QnoEd5lDfTQGZT4lxEVsmIqNdL2pjqqEBjOQlYCtcZwX3svhoigMgg 8BJfcW16IF6/uhmQySUKIma8emvJS6EQUsa9AoReTTUJKrGK0SLO58f8MhUrq0Hs /2oWb0eQrgnXzWGu/Vw8INsf0NYn/RdAJ0G6SNJRQJ6Y+54a3Ym0evLYmF2naJ3B 76EklejBY8WDQZQ30PnpQbR4uuH7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledvgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 10EDA328005E; Tue, 25 Feb 2020 04:46:54 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: dev@dpdk.org, Viacheslav Ovsiienko , Maxime Coquelin Date: Tue, 25 Feb 2020 10:46:53 +0100 Message-ID: <2091728.HovnAMPojK@xps> In-Reply-To: <1582620228-25629-1-git-send-email-matan@mellanox.com> References: <1582620228-25629-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix event setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2020 09:43, Matan Azrad: > The completion event mechanism should work only if at least one of the > virtqs has valid callfd to be notified on. > > When all the virtqs works with poll mode, the event mechanism should not > be configured. > > The driver didn't take it into account and crashed in the above case. > > Do not configure event interrupt when all the virtqs are in poll mode. > > Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") > > Signed-off-by: Matan Azrad Applied, thanks Note: there is no regression risk because it is fixing a new driver.