From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix '--huge-unlink' option
Date: Thu, 11 Oct 2018 11:40:26 +0200
Message-ID: <2096117.0V9xW38d9W@xps>
References: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com>
 <2b5aab7e-85cc-eb44-7da8-1bdc7484f298@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 44CD91B114
 for <dev@dpdk.org>; Thu, 11 Oct 2018 11:40:29 +0200 (CEST)
In-Reply-To: <2b5aab7e-85cc-eb44-7da8-1bdc7484f298@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/10/2018 10:13, Burakov, Anatoly:
> On 21-Sep-18 12:56 PM, Pawel Wodkowski wrote:
> > The final_va field is set during remap_segment() but this information is
> > not propagated to temporal copy of huge page memory configuration so the
> > unlink_hugepage_files() function wrongly assume that there is nothing to
> > unlink. Fix this issue by checking orig_va instead of final_va.
> > 
> > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> > To: Anatoly Burakov <anatoly.burakov@intel.com>
> > 
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks