From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples: detect build directory rather than hardcoding Date: Sat, 30 Mar 2019 01:14:14 +0100 Message-ID: <2099028.RPQpNJaItd@xps> References: <20190327135805.11067-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Bruce Richardson Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C54042BD3 for ; Sat, 30 Mar 2019 01:14:17 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/03/2019 16:02, Ferruh Yigit: > On 3/27/2019 1:58 PM, Bruce Richardson wrote: > > Most examples have in their makefiles a default RTE_TARGET directory to be > > used in case RTE_TARGET is not set. Rather than just using a hard-coded > > default, we can instead detect what the build directory is relative to > > RTE_SDK directory. > > > > This fixes a potential issue for anyone who continues to build using > > "make install T=x86_64-native-linuxapp-gcc" and skips setting RTE_TARGET > > explicitly, instead relying on the fact that they were building in a > > directory which corresponded to the example default path - which was > > changed to "x86_64-native-linux-gcc" by commit 218c4e68c1d9 ("mk: use > > linux and freebsd in config names"). > > > > Signed-off-by: Bruce Richardson > > Acked-by: Ferruh Yigit Applied, thanks