From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 17/41] doc: add NXP DPAA PMD documentation
Date: Tue, 19 Sep 2017 19:55:37 +0530
Message-ID: <20a0d11e-b011-9ad9-51b7-9657345c9e9d@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-18-shreyansh.jain@nxp.com>
 <b3f8fdbf-fd6e-c70e-fc3f-24cd5344793a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0067.outbound.protection.outlook.com [104.47.34.67])
 by dpdk.org (Postfix) with ESMTP id 1A94E1B1A8
 for <dev@dpdk.org>; Tue, 19 Sep 2017 16:14:44 +0200 (CEST)
In-Reply-To: <b3f8fdbf-fd6e-c70e-fc3f-24cd5344793a@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
>> +Config File Options
>> +~~~~~~~~~~~~~~~~~~~
>> +
>> +The following options can be modified in the ``config`` file.
>> +Please note that enabling debugging options may affect system performance.
>> +
>> +- ``CONFIG_RTE_LIBRTE_DPAA_BUS`` (default ``n``)
>> +
>> +  By default it is enabled only for defconfig_arm64-dpaa-* config.
>> +  Toggle compilation of the ``librte_bus_dpaa`` driver.
>> +
>> +- ``CONFIG_RTE_LIBRTE_DPAA_PMD`` (default ``n``)
>> +
>> +  By default it is enabled only for defconfig_arm64-dpaa-* config.
>> +  Toggle compilation of the ``librte_pmd_dpaa`` driver.
>> +
>> +- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``)
>> +
>> +  Toggle display of generic debugging messages
>> +
>> +- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_INIT`` (default ``n``)
>> +
>> +  Toggle display of initialization related messages.
>> +
>> +- ``CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS`` (default ``dpaa``)
> 
> There are a few new config missing in documentation.

Those are some non-documented/hidden toggles which I don't want to 
expose. Like *CHECKING. They are there only so that some deep debugging 
can be done - which would not be useful for someone not used to the base 
code.

Now that you have highlighted, I will see if we can entirely remove 
those non-documented toggles.

> 
>> +
>> +  This is not a DPAA specific configuration - it is a generic RTE config.
>> +  For optimal performance and hardware utilization, it is expected that DPAA
>> +  Mempool driver is used for mempools. For that, this configuration needs to
>> +  enabled.
>> +
>> +Environment Variables
>> +~~~~~~~~~~~~~~~~~~~~~
>> +
>> +DPAA drivers uses the following environment variables to configure its
>> +state during application initialization:
>> +
>> +- ``DPAA_NUM_RX_QUEUES`` (default 1)
> 
> Why not getting this value as device arg?

We had this discussion during DPAA2 as well. This time, I was not sure 
of how the device argument patches are turning out to be after the 
re-shuffle being done by Gaetan. So, I kept this as it is.

> 
> <...>
> 
>