From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction Date: Wed, 18 Jan 2017 11:46:25 +0100 Message-ID: <2101696.X900yayxyx@xps13> References: <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-2-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shreyansh Jain Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 35B11F960 for ; Wed, 18 Jan 2017 11:46:27 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id r144so18660897wme.1 for ; Wed, 18 Jan 2017 02:46:27 -0800 (PST) In-Reply-To: <1484735880-17178-2-git-send-email-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-18 16:07, Shreyansh Jain: > +void > +rte_bus_register(struct rte_bus *bus) > +{ > + RTE_VERIFY(bus); > + RTE_VERIFY(bus->name && strlen(bus->name)); > + > + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); > + RTE_LOG(DEBUG, EAL, "Registered [%s] bus.\n", bus->name); > +} > + > +void > +rte_bus_unregister(struct rte_bus *bus) > +{ > + TAILQ_REMOVE(&rte_bus_list, bus, next); > + RTE_LOG(INFO, EAL, "Unregistered [%s] bus.\n", bus->name); > +} This log should be DEBUG, consistently with "register" one. > +DPDK_17.02 { > + global: > + > + rte_bus_list; So finally, is it an useful symbol? Could it be removed from this patch?