From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix vdev allocation on non-0 numa socket Date: Wed, 30 Apr 2014 23:16:30 +0200 Message-ID: <2109617.VLhUbDmGTm@xps13> References: <1398863708-31078-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: maxime.leroy-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1398863708-31078-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > From: Maxime Leroy > > vdev ethdev can not be allocated on a numa socket that is not socket 0. > The reason comes from rte_eth_dev_allocate() which uses rte_socket_id() to > identify the socket on which vdev driver data should be allocated. > However, at this initialization step, rte_socket_id() always returns 0. > > Looking at rte_socket_id(), it needs rte_lcore_id() which uses the per-core > global _lcore_id variable. This variable is initialised by > eal_thread_init_master. > > So eal_thread_init_master should be called before rte_eal_vdev_init(). > > Signed-off-by: Maxime Leroy Acked-by: Thomas Monjalon Applied for version 1.6.0r2. Thanks -- Thomas