From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/af_packet: prefer snprintf against strncpy Date: Fri, 05 May 2017 17:59:30 +0200 Message-ID: <2111180.fiu7QRScOO@xps> References: <20170504111659.17670-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "John W. Linville" , Chas Williams To: Ferruh Yigit Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 917FF2B9E for ; Fri, 5 May 2017 17:59:32 +0200 (CEST) In-Reply-To: <20170504111659.17670-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/05/2017 13:16, Ferruh Yigit: > strncpy may left destination buffer not NULL terminated, switched using > snprintf to be sure destination buffer is NULL terminated. > > Coverity issue: 1407495 > Coverity issue: 1407498 > Fixes: cc68ac4847bc ("net/af_packet: support MTU change") > Fixes: 218259590ea4 ("net/af_packet: support promiscuous") > > Signed-off-by: Ferruh Yigit Applied, thanks