From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix build of external apps with clang on armv8 Date: Mon, 14 Jan 2019 19:47:34 +0100 Message-ID: <2111354.bjGcnvyq1o@xps> References: <20190114161442.8277-1-i.maximets@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Ilya Maximets , "dev@dpdk.org" , Pavan Nikhilesh , "stable@dpdk.org" , nd To: Honnappa Nagarahalli Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/01/2019 17:50, Honnappa Nagarahalli: > >=20 > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > But 'rte_atomic.h' is a generic header that included to the external ap= ps like > > OVS while building with DPDK. As a result, clang build of OVS fails on = ARMv8 > = ^^^^^^ > Typo, should be armv8. > Commit '40fd87486799' should have caught the typo issue. I don't want to = do this for every patch =F0=9F=98=8A Does 'check-git-log.sh' run automatica= lly? We are supposed to run it before submitting. And tree maintainers run it before applying. Anyway, it does check the title but not the message body.