From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] vfio: fix pci_vfio_map_resource Date: Fri, 15 Jul 2016 18:42:24 +0200 Message-ID: <2113476.6KVZGvHTNJ@xps13> References: <20160714153415.GA8329@gmail.com> <1468541710-47751-1-git-send-email-yongwang@vmware.com> <6504660.SWBHcg24lf@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, anatoly.burakov@intel.com, dan@kernelim.com, Ronghua Zhang To: Yong Wang Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B68B64CE4 for ; Fri, 15 Jul 2016 18:42:26 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id f126so32803409wma.1 for ; Fri, 15 Jul 2016 09:42:26 -0700 (PDT) In-Reply-To: <6504660.SWBHcg24lf@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-15 17:32, Thomas Monjalon: > 2016-07-14 17:15, Yong Wang: > > -=09=09=09=09void *second_addr =3D RTE_PTR_ADD(bar_addr, memreg[1].= offset); > > +=09=09=09=09void *second_addr =3D RTE_PTR_ADD(bar_addr, > > +=09=09=09=09=09=09=09=09memreg[1].offset - reg.offset); >=20 > There is an error for 32-bit: > =09error: cast to pointer from integer of different size > =09note: in expansion of macro =E2=80=98RTE_PTR_ADD=E2=80=99 It can fixed like this: - memreg[1].offset - reg.offset); + memreg[1].offset - + (uintptr_t)reg.offset);