From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC] cmdline: rework as a wrapper to libedit Date: Thu, 16 Nov 2017 19:05:03 +0100 Message-ID: <2113924.NBhQAuUZo3@xps> References: <1510234868-31053-1-git-send-email-adrien.mazarguil@6wind.com> <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com> <966D87A8-0B36-4B01-862C-EC9DB55667B3@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Yigit, Ferruh" , Adrien Mazarguil , Olivier Matz , "Wu, Jingjing" , dev@dpdk.org To: "Wiles, Keith" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 3DF331B2DF for ; Thu, 16 Nov 2017 19:05:05 +0100 (CET) In-Reply-To: <966D87A8-0B36-4B01-862C-EC9DB55667B3@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2017 18:27, Wiles, Keith: > > > On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote: > > > > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > > <...> > > > >>> I do not agree it has severed DPDK well, just look at test-pmd and the hoops people have to jump thru to get a new command or variation of an existing command integrated into test-pmd it is very difficult. Also if you look at the command sets in test-pmd they are very odd in that similar commands can some times be set up completely different as cmdline is too rigid and difficult to use. > >> > >> Testpmd is indeed messy, but this is not librte_cmdline's fundamental fault > >> in my opinion, more likely the result of using a copy/paste approach to new > >> commands due to lack of time or interest in making things nicer than the > >> bare minimum to validate features. There's no design direction for it hence > >> the lack of uniformity in the command hierarchy. > > > > Unrelated to cmdline discussion +1 for this paragraph. > > As a side note should CLI change the test-pmd commands to be more reasonable or maintain the current commands to not break testing. I would like to fix these commands with CLI, but as I have both built into test-pmd currently we can could keep the old cmdline commands and if you use the new CLI then it would be the new cleaner commands. I think we must keep the existing testpmd commands for a while to not disturb people using it integrated in their testing tools. If we introduce a new set of commands, we can define a deadline for removal of old commands.