From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/4] NIC filters support for generic filter Date: Wed, 11 Jun 2014 17:45:09 +0200 Message-ID: <2116871.SYCYqgDKRI@xps13> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8A789C6@SHSMSX104.ccr.corp.intel.com> <9BB6961774997848B5B42BEC655768F8A78A07@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Wu, Jingjing" Return-path: In-Reply-To: <9BB6961774997848B5B42BEC655768F8A78A07-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Jingjing, Please reply below the question. 2014-05-28 01:12, Wu, Jingjing: > You are discussing whether the APIs provide for NIC filters is generic > or not. About that we can use same API for a type of filter. For example, > if we want to configure ethertype filter, we can use the same API, no > matter the NIC is 82580, i350, 82576 or 82599. We think these NICs may be > most common used. I was wondering if this API can apply to non-Intel devices. But nobody talked about it. So let's forget it. My main concern is that Vladimir Medvedkin suggested another API and I'd like you give your opinion about it: http://dpdk.org/ml/archives/dev/2014-June/003053.html It offers pool number in configuration of the filters. Last comment: patches would be more pleasant to read with right alignment and spaces in comments. This is an extract to illustrate what I'm talking about: + uint16_t priority; /**< used when more than one filter matches */ + uint8_t dst_port_mask : 1, /**