From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 09/12] mk: add rte security into build
	system
Date: Fri, 20 Oct 2017 13:06:27 +0200
Message-ID: <2117737.hsY5RGJVTO@xps>
References: <20171006181151.4758-1-akhil.goyal@nxp.com>
 <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171014221734.15511-10-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
 hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
 aviadye@mellanox.com, sandeep.malik@nxp.com, jerin.jacob@caviumnetworks.com,
 john.mcnamara@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com,
 olivier.matz@6wind.com
To: Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C93541B1FF
 for <dev@dpdk.org>; Fri, 20 Oct 2017 13:06:29 +0200 (CEST)
In-Reply-To: <20171014221734.15511-10-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Why not merging this patch with the first one?

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +Security API - EXPERIMENTAL
> +M: Akhil Goyal <akhil.goyal@nxp.com>
> +M: Declan Doherty <declan.doherty@intel.com>
> +T: git://dpdk.org/draft/dpdk-draft-ipsec
> +F: lib/librte_security/
> +F: doc/guides/prog_guide/rte_security.rst

Do you really want to keep this draft tree?
If no, please do not reference it.

> +# Compile generic security library
> +#
> +CONFIG_RTE_LIBRTE_SECURITY=y
> +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n

No, DEBUG config options are prohibited.
The new log system allows to change the log level dynamically.

It was mentioned a lot of time in other patch series.
I was in the hope that everybody was now aware of the new log system
and the desire of removing all DEBUG options.