From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB57AC2D0DB for ; Thu, 30 Jan 2020 15:59:42 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 55B122082E for ; Thu, 30 Jan 2020 15:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="MP2yMulR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Xm2LMb2B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55B122082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F5EA1C022; Thu, 30 Jan 2020 16:59:41 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D78ED1BFB0 for ; Thu, 30 Jan 2020 16:59:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 356BF2209B; Thu, 30 Jan 2020 10:59:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 30 Jan 2020 10:59:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=TR+rsDGIDRO5rlB+d6nt9ehFt7nA4casTQR0tKHTbFc=; b=MP2yMulR3S2H ++8CPlcJKrZNz8YobR8LUqRJiwYTIfQPUfss3vgckz+raVlyjoC7cfpAxC9hlhr4 WOtd7wiFH8zadqug8tOXFOuu1ELwQS07r6SFKkBjTiSs/VxlcXwa6Vg3itUfJwbp jeiImD+2Ln3njv6iDBbkmL05UXKyMfo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TR+rsDGIDRO5rlB+d6nt9ehFt7nA4casTQR0tKHTb Fc=; b=Xm2LMb2BjDvomTKIOSEYhe1j97x4XMDnQe6hBVOlbLPToTCglBOEL2VpL LJI4lQU5U1OfI0kpy583cKhCJZ+xQ0UhIkK7yfK+kBNY/gWKAZGkFF5kkLZLhTPs w7fRVH8J0ZePbexlEis7vQ02JvzY/tvA07hgsMUt4/xenLo6yADFvyspRe2I5o+2 O0f5G8C1hn6VlGnm64bUOvq2T2bpb1zgb8UzR2LEC+m0fdjlUFt5X90Y5esuV3dn Y92AOLcu6wJmtxtGwPqn80kQXHE+uskjDALtfSFbVmyttrqCz2W7SISI++fbIGQ3 HwTmaQFtRvx+Svw2OOBR/6ffU+p2Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeekgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D3323060A88; Thu, 30 Jan 2020 10:59:37 -0500 (EST) From: Thomas Monjalon To: Anoob Joseph , "akhil.goyal@nxp.com" , "Trahe, Fiona" Cc: "dev@dpdk.org" , David Marchand , "Richardson, Bruce" , "nhorman@tuxdriver.com" , "Mcnamara, John" , "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "Yigit, Ferruh" Date: Thu, 30 Jan 2020 16:59:36 +0100 Message-ID: <2118076.C4sosBPzcN@xps> In-Reply-To: References: <20191220152058.10739-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/01/2020 14:06, Trahe, Fiona: > We were unaware the LIST_END change could constitute an ABI breakage, but can see how it affects the array size when picked up. > We're exploring options. > > I agree with Anoob's point that if we don't allow the LIST_END to be modified, then it means no feature can be implemented without ABI breakage. > Anyone object to removing those LIST_END elements - or have a better suggestion? Would have to be in 20.11 I suppose. Yes, having max value right after the last value is ridiculous, it prevents adding any value. In 20.11, we should remove all these *_END and *_MAX from API enums and replace them with a separate #define with reasonnable maximums.