From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix missing parenthesis Date: Fri, 16 Jan 2015 18:04:12 +0100 Message-ID: <2120377.FvxLenVaOl@xps13> References: <1420815925-7988-1-git-send-email-michalx.k.jastrzebski@intel.com> <29007273.jolbkK9tis@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Wodkowski, PawelX" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-01-16 09:40, Wodkowski, PawelX: > > Good catch! > > Was introduced in commit 4bdefaade6d1 (VMDQ enhancements). > > Note that quite often, when a patch contains too much things, > > we miss this kind of bugs. That's a reason to well split patches. > > What is most surprising I did not spotted this, neither the compiler > what I think it should. It was my IDE which pointed possible bug. > > Are we using '-Wparentheses' switch? If not, we should consider > to use this switch? It's already included in -Wall which is set in WERROR_FLAGS. -- Thomas