From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] ethdev: cleanup device ops struct
	whitespace
Date: Thu, 22 Dec 2016 16:28:43 +0100
Message-ID: <21208304.RglXy1FaaL@xps13>
References: <20161222115330.7164-1-ferruh.yigit@intel.com>
 <CALe+Z02WKE7rBvqt8ygHwnWv-OLcxqe5Uf+GSmhJMrTskL57BA@mail.gmail.com>
 <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Jan Blunck <jblunck@infradead.org>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f175.google.com (mail-wj0-f175.google.com
 [209.85.210.175]) by dpdk.org (Postfix) with ESMTP id 1FA6010D8B
 for <dev@dpdk.org>; Thu, 22 Dec 2016 16:28:44 +0100 (CET)
Received: by mail-wj0-f175.google.com with SMTP id sd9so45841049wjb.1
 for <dev@dpdk.org>; Thu, 22 Dec 2016 07:28:44 -0800 (PST)
In-Reply-To: <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-12-22 15:16, Ferruh Yigit:
> On 12/22/2016 3:10 PM, Jan Blunck wrote:
> > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >> - Grouped related items using empty lines
> > 
> > Reordering fields of a struct is breaking ABI. We should bump the
> > library version now.
> 
> You are right, sorry missed that.
> Intention was not to break the ABI, but cleanup.
> 
> Thomas,
> If it is too late, do you want me prepare a revert patch?

No
Please check doc/guides/rel_notes/deprecation.rst
We are going to break the ethdev ABI anyway.