From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] enic: fix warnings Date: Wed, 03 Dec 2014 16:05:16 +0100 Message-ID: <2126129.v20IaaVbE9@xps13> References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Sujith Sankar (ssujith)" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-03 14:52, Sujith Sankar: > > On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: > > >A lot of warnings were not seen because $(WERROR_FLAGS) was not set > >in the Makefile. But they appear with toolchains that enforce more checks. > > > >-Wno-deprecated seems useless. > >-Wno-strict-aliasing is added to avoid false positives. > > > >This patch cleans up unused variable, unused functions, wrong types, > >static declarations, etc. A lot of functions have unused parameters; > >it suggests that more clean-up could be needed. > > I shall look at it when I pull these changes to my repo. > What other toolchains did you check with? It's tested with many distributions, example CentOS 6. But adding the warnings as in this patch should be enough to test with any toolchain. -- Thomas