From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 1/6] vfio: allow DMA map of memory for the default vfio fd Date: Sat, 30 Mar 2019 15:29:32 +0100 Message-ID: <2126544.BhJDSFOOTj@xps> References: <828c4b2a57c5f6c4753898a6d3e96f0f9ded8171.1552206210.git.shahafs@mellanox.com> <1932739.UiCEsj7Gze@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com, yskoh@mellanox.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com, gaetan.rivet@6wind.com To: Shahaf Shuler Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 127FE3977 for ; Sat, 30 Mar 2019 15:29:38 +0100 (CET) In-Reply-To: <1932739.UiCEsj7Gze@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/03/2019 01:23, Thomas Monjalon: > 10/03/2019 09:27, Shahaf Shuler: > > Enable users the option to call rte_vfio_dma_map with request to map > > to the default vfio fd. > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Anatoly Burakov > > --- > > --- a/doc/guides/rel_notes/release_19_05.rst > > +++ b/doc/guides/rel_notes/release_19_05.rst > > @@ -136,6 +136,9 @@ ABI Changes > > +* vfio: Functions ``rte_vfio_container_dma_map`` and > > + ``rte_vfio_container_dma_unmap`` have been extended with an option to > > + request mapping or un-mapping to the default vfio container fd. > > Isn't it an API change rather than ABI? > It is adding -1 as a special value, I think it is not breaking > previous interface, and does not require a notification in the release notes. I will move it to the "API changes" section.