From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] eal: fix unlock in rte_eal_memzone_init Date: Thu, 20 Dec 2018 12:36:14 +0100 Message-ID: <2129438.97vpQxbemm@xps> References: <1544057251-17351-1-git-send-email-gfree.wind@vip.163.com> <1849368.QYu7HmPSto@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Gao Feng , dev@dpdk.org, "Burakov, Anatoly" To: Gao Feng Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 277F61BBE7 for ; Thu, 20 Dec 2018 12:36:18 +0100 (CET) In-Reply-To: <1849368.QYu7HmPSto@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/12/2018 12:20, Thomas Monjalon: > 07/12/2018 09:57, Burakov, Anatoly: > > On 07-Dec-18 1:20 AM, Gao Feng wrote: > > > The RTE_PROC_PRIMARY error handler lost the unlock statement in the > > > current codes. Now unlock and return in one place to fix it. > > > > > > Fixes: 49df3db84883 ("memzone: replace memzone array with fbarray") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gao Feng > > > --- > > Acked-by: Anatoly Burakov > > Applied, thanks > > I changed your author email (From:) to match the Signed-off-by one. > Please configure your git to use the Tencent email if possible. > Note you can have a "git From" address and use another one for sending. One more tip about patch formatting: I reworded the title to: memzone: fix unlock on initialization failure The prefix "memzone" gives the scope of the change. We decided that memzone is important enough to have its own scope prefix. You can find other prefixes in the git history. Then the rest of the title is written in plain english, detailing more the scope with "on initialization failure". Hope it helps, and welcome :)