From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 30/32] net/ice: support basic RX/TX
Date: Fri, 14 Dec 2018 17:41:46 +0100
Message-ID: <2134627.dYyTCR80XC@xps>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1544776518-91047-31-git-send-email-wenzhuo.lu@intel.com>
 <1db7247c-5332-c344-2304-70a2133fc3d9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org,
 Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A8C841B5D7
 for <dev@dpdk.org>; Fri, 14 Dec 2018 17:41:51 +0100 (CET)
In-Reply-To: <1db7247c-5332-c344-2304-70a2133fc3d9@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/12/2018 14:00, Ferruh Yigit:
> On 12/14/2018 8:35 AM, Wenzhuo Lu wrote:
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> <...>
> 
> > +
> > +	/* Check to make sure the last descriptor to clean is done */
> > +	desc_to_clean_to = sw_ring[desc_to_clean_to].last_id;
> > +	if (!(txd[desc_to_clean_to].cmd_type_offset_bsz &
> > +	    rte_cpu_to_le_64(ICE_TX_DESC_DTYPE_DESC_DONE))) {
> > +		PMD_TX_FREE_LOG(DEBUG, "TX descriptor %4u is not done "
> > +				"(port=%d queue=%d) value=0x%lx\n",
> > +				desc_to_clean_to,
> > +				txq->port_id, txq->queue_id,
> > +				txd[desc_to_clean_to].cmd_type_offset_bsz);
> 
> Causing build error for i686 [1], should use PRIx64 for 64bit variables.
> 
> Perhaps we should create a rule in checkpatch to check and warn %lx %lu formats
> `git grep -n '%l[xud]' drivers/net/ice/` shows only this occurrence in 'ice' but
> there are more in other drivers...

If it's clear to everybody that checkpatch can return some false positive,
yes I am for checking '%l[xud]'. It is most of the time a mistake.