From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] vfio: use right index when tracking devices in a vfio group Date: Wed, 10 May 2017 15:31:06 +0200 Message-ID: <21359258.pi0qq8Dcof@xps> References: <1494406463-24517-1-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Burakov, Anatoly" , "jerin.jacob@caviumnetworks.com" To: Alejandro Lucero Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9248C234 for ; Wed, 10 May 2017 15:31:08 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2017 11:11, Burakov, Anatoly: > From: Alejandro Lucero [mailto:alejandro.lucero@netronome.com] > > > > Previous fix for properly handling devices from the same VFIO group > > introduced another bug where the file descriptor of a kernel vfio group is > > used as the index for tracking number of devices of a vfio group struct > > handled by dpdk vfio code. Instead of the file descriptor itself, the vfio group > > object that file descriptor is registered with has to be used. > > > > This patch introduces specific functions for incrementing or decrementing > > the device counter for a specific vfio group using the vfio file descriptor as a > > parameter. Note the code is not optimized as the vfio group is found > > sequentially going through the vfio group array but this should not be a > > problem as this is not related to packet handling at all. > > > > Fixes: a9c349e3a100 ("vfio: fix device unplug when several devices per > > group") > > > > Signed-off-by: Alejandro Lucero > > Acked-by: Anatoly Burakov Applied, thanks