From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow Date: Mon, 14 Dec 2015 16:03:46 +0100 Message-ID: <2136605.pcfb1tFB10@xps13> References: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jijiang Liu Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 7EE6F37B2 for ; Mon, 14 Dec 2015 16:11:25 +0100 (CET) Received: by wmpp66 with SMTP id p66so64801687wmp.1 for ; Mon, 14 Dec 2015 07:11:25 -0800 (PST) In-Reply-To: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-09 13:37, Jijiang Liu: > The struct 'rte_eth_tunnel_flow' is only used by struct 'rte_eth_fdir_flow' now, but its name is generic, > and I plan to extend new fileds like below to support generic configuration for tunneling packet. You have not explained what the changes are for. So it's really difficult to have an opinion. Please describe an use case. PS: "filed" -> "field"