From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] kni: use netif_rx instead of
	netif_receive_skb in which ocurr deallock on userpace contex
Date: Thu, 17 Jul 2014 14:02:16 +0200
Message-ID: <2139993.JzhFVyBpua@xps13>
References: <1405093044-3264-1-git-send-email-blue119@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1405093044-3264-1-git-send-email-blue119-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi,

2014-07-11 23:37, Yao-Po Wang:
> Per netif_receive_skb function description, it may only be called from
> interrupt contex, but KNI is run on kthread that like as user-space
> contex. It may occur deallock, if netif_receive_skb called from kthread,
> so it should be repleaced by netif_rx or adding local_bh_disable/enable
> around netif_receive_skb.
> 
> Signed-off-by: Yao-Po Wang <blue119-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
>  			/* Call netif interface */
> -			netif_receive_skb(skb);
> +			netif_rx(skb);

Is there someone confident to approve this change?

-- 
Thomas