From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jincheng Miao Subject: Re: [PATCH 3/4] kni: replace strict_strtoul with kstrtoul Date: Wed, 10 Dec 2014 04:39:05 -0500 (EST) Message-ID: <2140629445.25897578.1418204345008.JavaMail.zimbra@redhat.com> References: <1418182383-5744-1-git-send-email-jmiao@redhat.com> <1663200.Cog0FQ0fDE@xps13> <957926828.25865702.1418201305408.JavaMail.zimbra@redhat.com> <1474820.EkRfEgf9QI@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <1474820.EkRfEgf9QI@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" ----- Original Message ----- > 2014-12-10 03:48, Jincheng Miao: > > > It seems you forgot to include the new compat.h. > > > > > > Did you do some tests with different Fedora/RHEL versions? > > > > Yes, missing compat.h in kni_vhost.c. > > > > > > And, I want to get your opinion about adding compat.h to kni and xen_dom0. > > The pros: easy to implement and minimal wrapper for older kernel. > > Yes I think it's the good approach. > > > The cons: there is so many compat.h, and the file kcompat.h also makes user > > confuse. > > Why kcompat makes user confuse? Because a lot of compat fallback in kcompat too. For example, for kni, there is compat.h and kcompat.h. I just confuse about it before. But if you agree it, I will also agree it. > > Do you think you could send a new version quickly to integrate it in the > next RC (probably today)? > > Please test it with RHEL. Yes, I am working on it. I will report my test result latter. Jincheng Miao > > Thanks > -- > Thomas >