From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 2/4] eal: add function to release internal
	resources
Date: Mon, 29 Jan 2018 19:20:14 +0100
Message-ID: <2141791.M0NvFpFgTI@xps>
References: <1517241642-161397-1-git-send-email-harry.van.haaren@intel.com>
 <1517243852-34142-1-git-send-email-harry.van.haaren@intel.com>
 <1517243852-34142-2-git-send-email-harry.van.haaren@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, vipin.varghese@intel.com
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 94A481BA2E
 for <dev@dpdk.org>; Mon, 29 Jan 2018 19:21:00 +0100 (CET)
In-Reply-To: <1517243852-34142-2-git-send-email-harry.van.haaren@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/01/2018 17:37, Harry van Haaren:
> @@ -79,6 +80,10 @@ rte_exit(int exit_code, const char *format, ...)
>  	va_end(ap);
>  
>  #ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR
> +	int ret = rte_eal_cleanup();

You should not declare a variable in the middle of the function.
Will fix on apply.

> +	if (ret)
> +		RTE_LOG(CRIT, EAL,
> +			"EAL could not release all resources, code %d\n", ret);
>  	exit(exit_code);
>  #else
>  	rte_dump_stack();