From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/bonding: fix link properties with autoneg Date: Wed, 14 Feb 2018 00:03:21 +0100 Message-ID: <2142911.RBZ8bQKsro@xps> References: <20180213225430.15556-1-3chas3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, declan.doherty@intel.com To: Chas Williams <3chas3@gmail.com>, Chas Williams Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F0FA11B31B for ; Wed, 14 Feb 2018 00:03:31 +0100 (CET) In-Reply-To: <20180213225430.15556-1-3chas3@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/02/2018 23:54, Chas Williams: > From: Chas Williams > > If a link is carrier down and using autonegotiation, then the PMD may not > have detected a speed yet. In this case the best we can do is ignore the > link speed and duplex since they aren't valid. To be completely correct, > there should be additional checks to prevent a slave that negotiates a > different speed from being activated. > > Signed-off-by: Chas Williams Please add Fixes line to all your fix patches. Thanks