From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 1/4] lib/librte_flow_classify: remove
	table id parameter from apis
Date: Wed, 10 Jan 2018 11:52:46 +0100
Message-ID: <2144605.X1J6VfJWv8@xps>
References: <20171215103924.5185-1-jasvinder.singh@intel.com>
 <2932732.5Kg9JDsi0f@xps>
 <54CBAA185211B4429112C315DA58FF6D332C3E4B@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BA0641B169
 for <dev@dpdk.org>; Wed, 10 Jan 2018 11:53:13 +0100 (CET)
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332C3E4B@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/01/2018 10:54, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 19/12/2017 15:29, Jasvinder Singh:
> > > This patch removes table id parameter from all the flow classify apis
> > > to reduce the complexity alongwith some code cleanup.
> > >
> > > The validate api is exposed as public api to allow user to validate
> > > the flow before adding it to the classifier.
> > 
> > This patch does not compile alone.
> > Should we merge all patches together?
> 
> No, It should compile alone. On my system it doesn't show any error and compilation goes successfully. Could you send me error log, etc ?

test/test/test_flow_classify.c:48:10: fatal error: too many arguments to
      function call, expected 6, have 7
                        NULL, NULL);
                              ^~~~

I guess it is expected that test and example does not compile after patch 1.
That's why I suggest to merge all 4 patches.