From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] test-pmd: show pci address in port info
Date: Wed, 29 Jul 2015 10:42:51 +0200
Message-ID: <2144726.adBAHMgyBQ@xps13>
References: <1438131904-23221-1-git-send-email-michael.qiu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Michael Qiu <michael.qiu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 7C851C4FA
 for <dev@dpdk.org>; Wed, 29 Jul 2015 10:44:08 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so15707478wib.0
 for <dev@dpdk.org>; Wed, 29 Jul 2015 01:44:08 -0700 (PDT)
In-Reply-To: <1438131904-23221-1-git-send-email-michael.qiu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-29 09:05, Michael Qiu:
> pci address is one important info for port.
> This patch make it visible for port info.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>

Maybe you missed this thread:
	http://dpdk.org/ml/archives/dev/2015-July/022107.html

> +	if (strncmp("0000:00:00.0", pci_addr, 12))
> +		printf("\nPCI address: %s", pci_addr);
> +	else
> +		printf("\nPCI address: N/A");

Checking a null PCI address to handle non-pci devices is ugly.
EAL must be reworked to correctly handle non-PCI devices.
Patches welcome.

This patch is rejected.