From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/mlx5: fix build on PPC64
Date: Wed, 07 Nov 2018 22:10:14 +0100
Message-ID: <2145434.ZaoFnF2QHS@xps>
References: <20180903092911.GU3695@6wind.com>
 <20181107160028.5938-1-thomas@monjalon.net>
 <30471765b219a14d31a795ea4d77eedb@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, adrien.mazarguil@6wind.com,
 shahafs@mellanox.com, yskoh@mellanox.com, gowrishankar.m@linux.vnet.ibm.com,
 chaozhu@linux.vnet.ibm.com, pradeep@us.ibm.com, tyos@jp.ibm.com
To: dwilder <dwilder@us.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F2CE9239
 for <dev@dpdk.org>; Wed,  7 Nov 2018 22:10:18 +0100 (CET)
In-Reply-To: <30471765b219a14d31a795ea4d77eedb@linux.vnet.ibm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/11/2018 20:05, dwilder:
> On 2018-11-07 08:00, Thomas Monjalon wrote:
> > The AltiVec header file breaks boolean type:
> > 
> > error: incompatible types when initializing type
> > '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
> > 
> > If __APPLE_ALTIVEC__ is defined, then bool type is redefined
> > and conflicts with stdbool.h.
> > 
> > There is no good solution to fix it for the whole project without
> > breaking something else, so a workaround is inserted in mlx5 PMD.
> > This workaround is not compatible with C++ but there is no C++ in DPDK.
> > 
> > Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Suggested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> <cut ....>
> 
> Tested-by: David Wilder <dwilder@us.ibm.com>
> 
> Hi Thomas
> 
> Thanks for re-posting this patch.  I see no build breaks on power8 or 
> power9 with this patch.  I tried both 18.11-rc1 and upstream (master).

It is not really a re-post. I took the last solution which was
proposed for EAL, and applied it to mlx5 only.