From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 1/2] ethdev: remove get_reg_length callback Date: Mon, 27 Jun 2016 17:19:43 +0200 Message-ID: <2151797.UCVmFz2S8u@xps13> References: <1466688410-13826-1-git-send-email-zr@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: remy.horton@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, dev@dpdk.org To: zr@semihalf.com Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 876912C2F for ; Mon, 27 Jun 2016 17:19:45 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id v199so104718545wmv.0 for ; Mon, 27 Jun 2016 08:19:45 -0700 (PDT) In-Reply-To: <1466688410-13826-1-git-send-email-zr@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-23 15:26, zr@semihalf.com: > From: Zyta Szpak > > Version 4 of fixing the assumption of that device registers > are always 32 bits long. rte_eth_dev_get_reg_length and > rte_eth_dev_get_reg_info callbacks did not provide register size > to the app in any way. It is needed to allocate proper number > of bytes before retrieving registers content with > rte_eth_dev_get_reg. This commit remove rte_eth_dev_get_reg_length > callback and adds width parameter to reg_info struct which makes > it possible to call rte_eth_dev_get_reg_info to get attributes > first. The drivers using this callback fill width and length > when call to function made with data=NULL. > > Signed-off-by: Zyta Szpak Please do not mention patch revision in the commit log. However you can add a changelog below the three dashes (with --annotate). And please use --in-reply-to to keep revisions in the same thread. Thanks