From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gregory Etelson <gregory@weka.io>
Subject: Re: IXBGE VF: link state detection
Date: Thu, 25 May 2017 06:48:13 +0300
Message-ID: <2154318.OTqaY7qzf9@polaris>
References: <8509342.3MbcxIPMKs@polaris> <20170524152647.3499551d@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, users@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 wenzhuo.lu@intel.com, "Dai, Wei" <wei.dai@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 0162B9145
 for <dev@dpdk.org>; Thu, 25 May 2017 05:48:15 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id 7so79170664wmo.1
 for <dev@dpdk.org>; Wed, 24 May 2017 20:48:15 -0700 (PDT)
In-Reply-To: <20170524152647.3499551d@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello,

After the revert, my environment reproduced link up detection failure almost immediately
With the patch the fault is rare.

Regards,
Gregory

On Wednesday, 24 May 2017 16:26:47 IDT Olivier Matz wrote:
> Hi Gregory,
> 
> On Wed, 24 May 2017 12:50:19 +0300, Gregory Etelson <gregory@weka.io> wrote:
> > Hello,
> > 
> > In my tests DPDK-17.05.0 process queries link state with rte_eth_link_get() each 50 msec
> > during 5-20 MB/sec IOs flow.
> > I turn Ethernet switch port down and up and check IXGBE VF PMD reaction to link state changes. 
> > VF PMD correctly recognize link down events but may miss link up.
> > When the fault occurs, subsequent calls to rte_eth_link_get will return link_status == 0 forever.
> > I need to reset DPDK process to get correct link state value.
> > My debugging shows that in case of the fault, mbx->ops.read(hw, &in_msg, 1, 0) in ixgbe_check_mac_link_vf
> > keeps returning non-zero value
> 
> It looks there is at least one issue with
> commit c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> 
> Someone already complained about a problem related to the link status
> on ixgbe (which is probably different than yours):
> http://dpdk.org/ml/archives/dev/2017-May/066238.html
> 
> Anyway, maybe you can try to revert this patch and see if it
> solves your issue?
> 
> Thanks
> Olivier
>