From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 06/10] mbuf_offload: library to support
	attaching offloads to a mbuf
Date: Fri, 13 Nov 2015 16:59:54 +0100
Message-ID: <21617013.7y6t1r3jyk@xps13>
References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-7-git-send-email-declan.doherty@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 970AE937C
 for <dev@dpdk.org>; Fri, 13 Nov 2015 17:01:08 +0100 (CET)
Received: by wmww144 with SMTP id w144so34567253wmw.1
 for <dev@dpdk.org>; Fri, 13 Nov 2015 08:01:08 -0800 (PST)
In-Reply-To: <1447176763-19303-7-git-send-email-declan.doherty@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-10 17:32, Declan Doherty:
> @@ -841,6 +844,9 @@ struct rte_mbuf {
> +
> +       /* Chain of off-load operations to perform on mbuf */
> +       struct rte_mbuf_offload *offload_ops;
>  } __rte_cache_aligned;

Why is there a pointer in the mbuf structure?
Can it be a metadata for the crypto layer instead?

More generally, I have the feeling that the idea behind this new API
is not enough explained. How is it related to the ethernet offloads?
Could you add a doxygen explanation starting with
/**
 * @file

About doxygen, please think to integrate your new header.