From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Inter-PMD dependencies when building shared libraries
Date: Thu, 05 Oct 2017 14:32:06 +0200
Message-ID: <2164137.oDFHlng5hp@xps>
References: <9184057F7FC11744A2107296B6B8EB1E14005F70@FMSMSX108.amr.corp.intel.com>
 <20171005121254.r3h43hxs423dxr4k@glumotte.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "'Jacob, Jerin'" <Jerin.JacobKollanukkaran@cavium.com>,
 "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
 bruce.richardson@intel.com
To: Olivier MATZ <olivier.matz@6wind.com>, "Eads, Gage" <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D365737B1
 for <dev@dpdk.org>; Thu,  5 Oct 2017 14:32:11 +0200 (CEST)
In-Reply-To: <20171005121254.r3h43hxs423dxr4k@glumotte.dev.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/10/2017 14:12, Olivier MATZ:
> On Mon, Oct 02, 2017 at 08:48:29PM +0000, Eads, Gage wrote:
> > I believe I've spotted an issue in the way inter-PMD dependencies are handled when building shared libraries. The depdirs_rule in mk/rte.subdir.mk relies on DEPDIRS-xyz containing the names of subdirectories that xyz depends on. In mk/rte.lib.mk, these DEPDIRS are converted into LDLIBS. This works when the subdirectory names match the library names (i.e. any of the libraries under lib/). However when the dependency is on a PMD, the subdirectory and library names don't match.
[...]
> To solve this, we can either:
> 
> 1- do additional fixes of the "dir name -> lib name" conversion in
>    lib.mk for all this list above, as we are doing for eal or
>    ethdev. This looks feasible, but quite ugly.
> 
> 2- rename all directories to match the libname (ex: drivers/net/null
>    becomes drivers/net/librte_pmd_null). Looks to be a bad idea ;)
> 
> 3- stop to generate the list of libraries from depdirs: DEPDIRS is
>    kept for directory dependency at build, and the list of libraries
>    is advertised in LDLIBS variable, in each Makefile.
> 
> My vote would go for option 3.

We could have several libraries in the same directory.
So I vote for option 4:

4- Replace directory dependencies with library dependencies in makefiles.
   And convert libs to dirs with an autogenerated table.

Note: that's why I don't like recursive makefiles like we have
in the DPDK build system. It forces us to deal with directories
instead of just declaring dependencies on real file targets.