From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] cfgfile: fix resource leak Date: Tue, 07 Nov 2017 02:20:45 +0100 Message-ID: <2164750.0ENp7ujehH@xps> References: <1508998869-4963-1-git-send-email-jacekx.piasecki@intel.com> <60ABE07DBB3A454EB7FAD707B4BB158213C4B1B1@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Jastrzebski, MichalX K" , "Dumitrescu, Cristian" To: "Piasecki, JacekX" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 56B351B37C for ; Tue, 7 Nov 2017 02:20:47 +0100 (CET) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213C4B1B1@IRSMSX109.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2017 17:08, Jastrzebski, MichalX K: > > > > Unsuccesfull memory allocation for elements inside cfgfile > > structure could result in resource leak. > > Fixed by pointer verification after each malloc, > > if malloc fail - error branch is proceeded with freeing memory. > > > > Coverity issue: 195032 > > Fixes: d4cb8197589d ("cfgfile: support runtime modification") > > Cc: jacekx.piasecki@intel.com > > Cc: stable@dpdk.org No need to Cc stable for bugs introduced in current release. > > Signed-off-by: Jacek Piasecki > > Acked-by: Michal Jastrzebski Applied, thanks