From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] examples/kni: check if pci_dev isn't
	NULL before using it
Date: Wed, 25 Oct 2017 00:05:19 +0200
Message-ID: <2165906.4gmW2yU9sD@xps>
References: <1508154348-10988-1-git-send-email-tdu@semihalf.com>
 <1508154348-10988-2-git-send-email-tdu@semihalf.com>
 <fff0add4-bf1b-50d8-dafc-e6530507cbdc@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 64E9F2935
 for <dev@dpdk.org>; Wed, 25 Oct 2017 00:05:21 +0200 (CEST)
In-Reply-To: <fff0add4-bf1b-50d8-dafc-e6530507cbdc@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/10/2017 02:26, Ferruh Yigit:
> On 10/16/2017 4:45 AM, Tomasz Duszynski wrote:
> > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev
> > dereferencing it will cause segmentation fault as by default
> > it's set to NULL in rte_eth_dev_info_get().
> > 
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Fixed title: examples/kni: check PCI info not NULL before reading

Applied, thanks

The patch 2/2 is left alone as it may be unneeded.