From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 08/11] app/test: convert current pci_test
	into a single test case
Date: Fri, 13 May 2016 17:35:42 +0200
Message-ID: <2173920.FKvWuSveuV@xps13>
References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com>
 <1590761.7jRYD2v3H6@xps13> <20160513171942.231577b4@pcviktorin.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 152F99A9E
 for <dev@dpdk.org>; Fri, 13 May 2016 17:35:44 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id e201so27396795wme.0
 for <dev@dpdk.org>; Fri, 13 May 2016 08:35:44 -0700 (PDT)
In-Reply-To: <20160513171942.231577b4@pcviktorin.fit.vutbr.cz>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-13 17:19, Jan Viktorin:
> On Thu, 12 May 2016 17:34:13 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2016-05-10 20:13, Jan Viktorin:
> > > The current test_pci is just a single test case that tests the blacklisting
> > > of devices. Rename it to test_pci_blacklist and call it from the test_pci.  
> > 
> > The functions are also moved. It is confusing.
> > Maybe this patch can be squashed with the previous one.
> > 
> 
> Well, I wanted to separate the functional changes from cosmetic ones.
> The goal here is to extract the setup and cleanup phases from the orignal
> test. Would be better to just change the description?
> 
> ---
> 
> app/test: extract setup and cleanup phase from pci_test
> 
> The original test_pci contains the setup and cleanup phase in its body.
> By extracting this code out, we can take advantage of this code for other
> (future) tests as well.
> 
> The test_pci is renamed to test_pci_blacklist - it's only a single test
> case (others will follow) now.
> 
> ---
> 
> Probably, it can be splitted (instead of squashed with a previous one) to
> "extract setup and cleanup" and "rename to test_pci_blacklist".

Not a big deal, I will check in v3.
Thanks