From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 2/4] examples/ip_pipeline: fix build
	for	x86_64 without SSE4.2
Date: Wed, 30 Mar 2016 17:50:18 +0200
Message-ID: <2177795.lZF7jR9sKJ@xps13>
References: <1455605170-16137-1-git-send-email-thomas.monjalon@6wind.com>
 <1519299.Ljb19TASP1@xps13>
 <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Singh, Jasvinder" <jasvinder.singh@intel.com>, "Zhang,
 Roy Fan" <roy.fan.zhang@intel.com>, "Hunt, David" <david.hunt@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id AF4FA2C11
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:18:52 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id 20so78385896wmh.1
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:18:52 -0700 (PDT)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-30 14:15, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-03-30 13:57, Dumitrescu, Cristian:
> > > I think the correct fix is:
> > > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2)
> > || defined(RTE_MACHINE_CPUFLAG_CRC32))
> > >
> > > We'll test it and send a patch asap.
> > 
> > I had prepared this patch. Please be inspired:
> > 
> >     examples/ip_pipeline: fix SSE4.2 optimization branch
> > 
> >     The branch was disabled because of a typo in the SSE4.2 flag.
> >     Change also the x86_64 flag to use a DPDK one.
> > 
> >     Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without
> > SSE4.2")
> > 
> > -#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2)
> > +#if defined(RTE_ARCH_X86_64) &&
> > defined(RTE_MACHINE_CPUFLAG_SSE4_2)
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

I thought you wanted to send a patch with another CPUFLAG (CRC32)?