From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 4/7] compressdev: remove driver name from
	logs
Date: Mon, 15 Oct 2018 10:51:33 +0200
Message-ID: <2178625.HfJZiVN0zS@xps>
References: <20180907230958.21402-1-thomas@monjalon.net>
 <20181014204747.26621-1-thomas@monjalon.net>
 <20181014204747.26621-5-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com,
 ferruh.yigit@intel.com, Fiona Trahe <fiona.trahe@intel.com>,
 Ashish Gupta <ashish.gupta@caviumnetworks.com>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A2B7F2BC8
 for <dev@dpdk.org>; Mon, 15 Oct 2018 10:51:34 +0200 (CEST)
In-Reply-To: <20181014204747.26621-5-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+Cc Fiona and Ashish

14/10/2018 22:47, Thomas Monjalon:
> The logs printed by COMPRESSDEV_LOG were prefixed with the driver name.
> 
> In order to avoid assigning the driver before the end of the probing,
> the driver name is removed from the compressdev library logs.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/librte_compressdev/rte_compressdev_pmd.c | 23 ++++++++------------
>  1 file changed, 9 insertions(+), 14 deletions(-)
> 
> diff --git a/lib/librte_compressdev/rte_compressdev_pmd.c b/lib/librte_compressdev/rte_compressdev_pmd.c
> index 7de4f339e..95beb26ab 100644
> --- a/lib/librte_compressdev/rte_compressdev_pmd.c
> +++ b/lib/librte_compressdev/rte_compressdev_pmd.c
> @@ -92,24 +92,20 @@ rte_compressdev_pmd_create(const char *name,
>  	struct rte_compressdev *compressdev;
>  
>  	if (params->name[0] != '\0') {
> -		COMPRESSDEV_LOG(INFO, "[%s] User specified device name = %s\n",
> -				device->driver->name, params->name);
> +		COMPRESSDEV_LOG(INFO, "User specified device name = %s\n",
> +				params->name);
>  		name = params->name;
>  	}
>  
> -	COMPRESSDEV_LOG(INFO, "[%s] - Creating compressdev %s\n",
> -			device->driver->name, name);
> +	COMPRESSDEV_LOG(INFO, "Creating compressdev %s\n", name);
>  
> -	COMPRESSDEV_LOG(INFO,
> -	"[%s] - Init parameters - name: %s, socket id: %d",
> -			device->driver->name, name,
> -			params->socket_id);
> +	COMPRESSDEV_LOG(INFO, "Init parameters - name: %s, socket id: %d",
> +			name, params->socket_id);
>  
>  	/* allocate device structure */
>  	compressdev = rte_compressdev_pmd_allocate(name, params->socket_id);
>  	if (compressdev == NULL) {
> -		COMPRESSDEV_LOG(ERR, "[%s] Failed to allocate comp device %s",
> -				device->driver->name, name);
> +		COMPRESSDEV_LOG(ERR, "Failed to allocate comp device %s", name);
>  		return NULL;
>  	}
>  
> @@ -123,8 +119,8 @@ rte_compressdev_pmd_create(const char *name,
>  
>  		if (compressdev->data->dev_private == NULL) {
>  			COMPRESSDEV_LOG(ERR,
> -		"[%s] Cannot allocate memory for compressdev %s private data",
> -					device->driver->name, name);
> +					"Cannot allocate memory for compressdev"
> +					" %s private data", name);
>  
>  			rte_compressdev_pmd_release_device(compressdev);
>  			return NULL;
> @@ -141,8 +137,7 @@ rte_compressdev_pmd_destroy(struct rte_compressdev *compressdev)
>  {
>  	int retval;
>  
> -	COMPRESSDEV_LOG(INFO, "[%s] Closing comp device %s",
> -			compressdev->device->driver->name,
> +	COMPRESSDEV_LOG(INFO, "Closing comp device %s",
>  			compressdev->device->name);
>  
>  	/* free comp device */
>