From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v10 0/5] add unit tests for bitrate,
	latency and pdump libraries
Date: Fri, 03 Aug 2018 16:11:03 +0200
Message-ID: <2179132.BP2OZL8SCC@xps>
References: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com>
 <29483712.ychiUti4Sd@xps>
 <3AEA2BF9852C6F48A459DA490692831F2A378E6C@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "Somarowthu, Naga SureshX" <naga.sureshx.somarowthu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 18D851B561
 for <dev@dpdk.org>; Fri,  3 Aug 2018 16:11:11 +0200 (CEST)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A378E6C@IRSMSX109.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/08/2018 15:45, Pattan, Reshma:
> Hi Thomas,
>=20
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> >=20
> > 01/08/2018 00:18, Reshma Pattan:
> > > v10: fixed clang compiler issues and freed latency stats memzone in
> > > latency stats unit tests.
> > > v9: rebased ontop of latest autotest changes and added new tests to
> > > the autotest list
> > > v8: renamed commit headline and freed the metrics memzone for bitrate
> > > ut
> > > v7: removed unused macros and corrected the comment
> > > v6: updated ring variable appropriately
> > > v5: rebased, freed pools and rings, created common patch set
> > > ---
> >=20
> > Sorry, the integration of this patchset is very painful.
> >=20
> > After asking for rebase, for clang fix, there are still some basic erro=
rs with 32-
> > bit compilation:
> >=20
> > 	test_latencystats.c:131:21: error:
> > 	format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long in=
t=E2=80=99,
> > 	but argument 2 has type =E2=80=98uint64_t=E2=80=99 {aka =E2=80=98long =
long unsigned int=E2=80=99}
> >=20
> > linkage:
> >=20
> > 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
> > reference to `test_pdump'
> >=20
> > or even MAINTAINERS file:
> >=20
> > 	test/test/sample_packet_forward.c
> > 	test/test/sample_packet_forward.h
> > 	test/test/test_bitratestats.c
> > 	test/test/test_latencystats.c
> >=20
> > I have already spent too much time on it, despite it is not fixing 18.0=
8.
> >=20
> > Please do a complete detailed review of this series, so it can be consi=
dered for
> > 18.11.
> >=20
>=20
> We missed to do these basic checks, apologies for consuming your time.
>  Naga Suresh has now proactively worked on fixing these issues and runnin=
g pre checks on patches and addressed in v12.
> The earlier versions were reviewed by me, Remy and Anatoly . So we reques=
t you to consider latest patches for 18.08,
> until unless they don=E2=80=99t give any last minute  surprises.

Sorry, I consider it is now too late for such patch in 18.08.
It is not fixing any issue.

Last days of 18.08 cycle will be really focus on bugs and doc.