From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: remove deprecated statistics Date: Tue, 19 Apr 2016 16:13:58 +0200 Message-ID: <2181162.yfzPt0qCzR@xps13> References: <1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: maryam.tahhan@intel.com, harry.van.haaren@intel.com Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5955C37B1 for ; Tue, 19 Apr 2016 16:14:01 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id l6so28556597wml.1 for ; Tue, 19 Apr 2016 07:14:01 -0700 (PDT) In-Reply-To: <1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-19 16:03, Thomas Monjalon: > Some statistics were deprecated since release 2.1 (49f386542af4). > > The last deprecated counter to be used was imcasts. > > The new counters should be added to extended statistics. > > Signed-off-by: Thomas Monjalon [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -200,27 +200,9 @@ struct rte_eth_stats { > /**< Total of RX packets dropped by the HW, > * because there are no available mbufs (i.e. RX queues are full). > */ > - uint64_t ibadcrc __rte_deprecated; > - /**< Deprecated; Total of RX packets with CRC error. */ > - uint64_t ibadlen __rte_deprecated; > - /**< Deprecated; Total of RX packets with bad length. */ > uint64_t ierrors; /**< Total number of erroneous received packets. */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > - uint64_t imcasts; > - /**< Deprecated; Total number of multicast received packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */ > - uint64_t fdirmatch __rte_deprecated; > - /**< Deprecated; Total number of RX packets matching a filter. */ > - uint64_t fdirmiss __rte_deprecated; > - /**< Deprecated; Total number of RX packets not matching any filter. */ > - uint64_t tx_pause_xon __rte_deprecated; > - /**< Deprecated; Total nb. of XON pause frame sent. */ > - uint64_t rx_pause_xon __rte_deprecated; > - /**< Deprecated; Total nb. of XON pause frame received. */ > - uint64_t tx_pause_xoff __rte_deprecated; > - /**< Deprecated; Total nb. of XOFF pause frame sent. */ > - uint64_t rx_pause_xoff __rte_deprecated; > - /**< Deprecated; Total nb. of XOFF pause frame received. */ > uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; > /**< Total number of queue RX packets. */ > uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; I suggest to remove also the loopback statistics which are implemented only for igbvf and available as extended stats: --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -213,14 +213,6 @@ struct rte_eth_stats { /**< Total number of successfully transmitted queue bytes. */ uint64_t q_errors[RTE_ETHDEV_QUEUE_STAT_CNTRS]; /**< Total number of queue packets received that are dropped. */ - uint64_t ilbpackets; - /**< Total number of good packets received from loopback,VF Only */ - uint64_t olbpackets; - /**< Total number of good packets transmitted to loopback,VF Only */ - uint64_t ilbbytes; - /**< Total number of good bytes received from loopback,VF Only */ - uint64_t olbbytes; - /**< Total number of good bytes transmitted to loopback,VF Only */ }; --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -1805,10 +1805,6 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats) rte_stats->ibytes = hw_stats->gorc; rte_stats->opackets = hw_stats->gptc; rte_stats->obytes = hw_stats->gotc; - rte_stats->ilbpackets = hw_stats->gprlbc; - rte_stats->ilbbytes = hw_stats->gorlbc; - rte_stats->olbpackets = hw_stats->gptlbc; - rte_stats->olbbytes = hw_stats->gotlbc; } I'll send a v2 if no objection.