From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH] linux: fix race condition
Date: Fri, 11 Apr 2014 08:47:01 -0700 (PDT)
Message-ID: <21832480.IqanGZ8f4h@xps13>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD0109D69F@BPXM14GP.gisp.nec.co.jp>
 <2469493.IGjSGz2PDr@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <2469493.IGjSGz2PDr@platinum>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-04-11 11:41, Olivier MATZ:
> On Thursday, April 03, 2014 07:35:50 AM Hiroshi Shimamoto wrote:
> > From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > 
> > Same as PMD, there is a race condition between host and guest
> > in the guest MEMNIC kernel driver.
> > 
> > Guest PMD                 Host
> > Thread-A     Thread-B     vSwitch
> > 
> >    |idx=0       |idx=0       |p[0] st!=2
> >    |cmpxchg     |            |
> >    |p[0] st->1  |            |
> >    |idx=1       |            |
> >    |fill data   |            |
> >    |p[0] st->2  |            |p[0] st==2
> >    |
> >    |            |            |receive data
> >    |            |            |p[0] st->0
> >    |            |
> >    |            |cmpxchg     |
> >    |            |success     |p[1] st!=2
> >    |            |p[0] st->1  |
> >    |            |
> >                   This is BAD
> > 
> > Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > ---
> > 
> >  linux/memnic_net.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> 
> Reviewed-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied

Thanks
-- 
Thomas