From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] Fill speed_capa for virtio
Date: Fri, 10 Feb 2017 09:41:26 +0100
Message-ID: <2185375.0v2z51C3zP@xps13>
References: <20170202092357.58508-1-ibarnea@cisco.com>
 <1524443.RGCIa5yWyV@xps13> <C61299CA-E83A-41F3-ACEE-AB5E82C65122@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Ido Barnea (ibarnea)" <ibarnea@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 0AE68201
 for <dev@dpdk.org>; Fri, 10 Feb 2017 09:41:27 +0100 (CET)
Received: by mail-wm0-f50.google.com with SMTP id v77so41793771wmv.0
 for <dev@dpdk.org>; Fri, 10 Feb 2017 00:41:27 -0800 (PST)
In-Reply-To: <C61299CA-E83A-41F3-ACEE-AB5E82C65122@cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-02-10 07:49, Ido Barnea:
> On 09/02/2017, 6:19 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
> >2017-02-02 12:05, Ido Barnea:
> >> From: Ido Barnea <ibarnea@cisco.com>
> >> 
> >> Signed-off-by: Ido Barnea <ibarnea@cisco.com>
> >> ---
> >>  drivers/net/virtio/virtio_ethdev.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >> index d1ff234..1d572b5 100644
> >> --- a/drivers/net/virtio/virtio_ethdev.c
> >> +++ b/drivers/net/virtio/virtio_ethdev.c
> >> @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> >>  		(1ULL << VIRTIO_NET_F_HOST_TSO6);
> >>  	if ((hw->guest_features & tso_mask) == tso_mask)
> >>  		dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO;
> >> +	dev_info->speed_capa = ETH_LINK_SPEED_10G;
> >
> >Why 10G ?
> >Yuanhan, any opinion?
> 
> Just wanted this to be consistent with below (From virtio_dev_link_update):
> link.link_speed = SPEED_10G;

OK, that's the kind of justification which are good to have in
the commit message.