From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 1/6] szedata2: add new poll mode driver
Date: Fri, 20 Nov 2015 16:04:21 +0100
Message-ID: <2187677.AtrVqmgt0N@xps13>
References: <1442565172-5338-1-git-send-email-matejvido@gmail.com>
 <1447165098-6412-1-git-send-email-matejvido@gmail.com>
 <1447165098-6412-2-git-send-email-matejvido@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Viktor Pus <pus@cesnet.cz>
To: Matej Vido <matejvido@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 4802E5A6C
 for <dev@dpdk.org>; Fri, 20 Nov 2015 16:05:37 +0100 (CET)
Received: by wmec201 with SMTP id c201so24744640wme.1
 for <dev@dpdk.org>; Fri, 20 Nov 2015 07:05:36 -0800 (PST)
In-Reply-To: <1447165098-6412-2-git-send-email-matejvido@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

I'm doing some last checks before merging.

The libsze2 depends on libcommlbr so it would be better to list it on
https://www.liberouter.org/technologies/netcope/access-to-libsze2-library

A patch is needed in mk/ to allow linking these dependencies from a
non-standard directory: http://dpdk.org/dev/patchwork/patch/9023

As only 64-bit versions of the libraries are provided, I guess we
could mention it is currently supported only on x86-64.


2015-11-10 15:18, Matej Vido:
> +static void
> +eth_stats_get(struct rte_eth_dev *dev,
> +		struct rte_eth_stats *igb_stats)
> +{

igb_stats is a name inherited from old times. It is related to the first
DPDK driver (igb).
I will rename it to "stats".

[...]
> +       long int value;
> +
> +       value = strtol(mask_str, &endptr, 0);
> +       if (*endptr != '\0' || value > UINT32_MAX || value < 0)

This check would not compile in 32-bit environment (which is not supported).

[...]
> +static int
> +rte_eth_from_szedata2(const char *name,
> +               struct rxtx_szedata2 *szedata2,
> +               const unsigned numa_node)
> +{
> +       struct pmd_internals *internals = NULL;
> +       struct rte_eth_dev *eth_dev = NULL;
> +       struct rte_eth_dev_data *data = NULL;

This data variable is not used before the patch 4/6.
I will move it.