From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] nfp: new poll mode driver for netronome nfp-6xxx card Date: Mon, 26 Oct 2015 15:46:30 +0100 Message-ID: <2192125.8cJDpqYsAL@xps13> References: <1445596563-16818-1-git-send-email-alejandro.lucero@netronome.com> <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Alejandro.Lucero" Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 25FE95A76 for ; Mon, 26 Oct 2015 15:47:40 +0100 (CET) Received: by wicll6 with SMTP id ll6so117827035wic.0 for ; Mon, 26 Oct 2015 07:47:40 -0700 (PDT) In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-23 11:36, Alejandro.Lucero: > From: "Alejandro.Lucero" > > This patch adds a new PMD for using PCI Virtual Functions with Netronome > nfp6000 card. > > Signed-off-by: Alejandro.Lucero > Signed-off-by: Rolf.Neugebauer > --- > drivers/net/nfp/Makefile | 88 ++ > drivers/net/nfp/nfp_net.c | 2495 ++++++++++++++++++++++++++++++++++++++++ > drivers/net/nfp/nfp_net_ctrl.h | 290 +++++ > drivers/net/nfp/nfp_net_logs.h | 75 ++ > drivers/net/nfp/nfp_net_pmd.h | 434 +++++++ It seems this driver is not integrated in the build system. Please avoid such huge patch and submit piece by piece. Example: - patch 1 for the basic init - patch 2 for Rx/Tx - patch 3 for RSS - patch 4 for statistics It will be easier to review. It would be also appreciated to have a doc in doc/guides/nics and an entry in the release notes. Thanks