From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 3/4] examples: add l3fwd-thread example in
	performance-thread
Date: Mon, 07 Dec 2015 03:36:12 +0100
Message-ID: <21971802.WvAiNsWy31@xps13>
References: <1449159683-7092-3-git-send-email-ian.betts@intel.com>
 <1449225265-14480-1-git-send-email-ian.betts@intel.com>
 <1449225265-14480-4-git-send-email-ian.betts@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ian Betts <ian.betts@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id E4F1E9418
 for <dev@dpdk.org>; Mon,  7 Dec 2015 03:37:24 +0100 (CET)
Received: by wmuu63 with SMTP id u63so123356575wmu.0
 for <dev@dpdk.org>; Sun, 06 Dec 2015 18:37:24 -0800 (PST)
In-Reply-To: <1449225265-14480-4-git-send-email-ian.betts@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

I had no time to check how it works.
I'm just surprised that you introduce a new config option.

2015-12-04 10:34, Ian Betts:
> --- a/config/defconfig_x86_64-native-linuxapp-gcc
> +++ b/config/defconfig_x86_64-native-linuxapp-gcc
> @@ -40,3 +40,5 @@ CONFIG_RTE_ARCH_64=y
>  
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
> +
> +CONFIG_RTE_PERFORMANCE_THREAD=y
> diff --git a/config/defconfig_x86_64-native-linuxapp-icc b/config/defconfig_x86_64-native-linuxapp-icc
> index 71d1e28..4c8e6ac 100644
> --- a/config/defconfig_x86_64-native-linuxapp-icc
> +++ b/config/defconfig_x86_64-native-linuxapp-icc
> @@ -40,3 +40,5 @@ CONFIG_RTE_ARCH_64=y
>  
>  CONFIG_RTE_TOOLCHAIN="icc"
>  CONFIG_RTE_TOOLCHAIN_ICC=y
> +
> +CONFIG_RTE_PERFORMANCE_THREAD=y
> diff --git a/examples/Makefile b/examples/Makefile
> index 5dd2c53..c7e786d 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -77,5 +77,6 @@ DIRS-y += vmdq
>  DIRS-y += vmdq_dcb
>  DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto
> +DIRS-$(CONFIG_RTE_PERFORMANCE_THREAD) += performance-thread

I think this option should be removed.