From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps
	link speeds
Date: Thu, 03 Mar 2016 10:28:27 +0100
Message-ID: <2201521.3lr0Br3EYS@xps13>
References: <1456954614-119304-1-git-send-email-stephen.hurd@broadcom.com>
 <1456978137-98097-2-git-send-email-stephen.hurd@broadcom.com>
 <56D7ED89.8060903@netinsight.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Simon =?ISO-8859-1?Q?K=E5gstr=F6m?= <simon.kagstrom@netinsight.net>,
 Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 06CA42B98
 for <dev@dpdk.org>; Thu,  3 Mar 2016 10:30:03 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id l68so122155586wml.0
 for <dev@dpdk.org>; Thu, 03 Mar 2016 01:30:03 -0800 (PST)
In-Reply-To: <56D7ED89.8060903@netinsight.net>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2016-03-03 08:53, Simon K=E5gstr=F6m:
> Hi!
>=20
> On 2016-03-03 05:08, Stephen Hurd wrote:
> > Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps =
links

Stephen,
you could be interested in the rework done by Marc Sune:
=09http://dpdk.org/dev/patchwork/patch/10919/

> I realize this is a more general question, but is it really meaningfu=
l
> to have macros for all possible link speeds? We're working on a PMD
> driver with a channelized interface exposed as DPDK ports. Each chann=
el
> can be configured with an arbitrary speed, so e.g., 1337 Mbps is also=

> possible.

What is the benefit? Why not negotiate the maximum capability of the pe=
er?

> To me, it would seem more natural to just have a number in mbits for =
the
> link speed.

Please jump in the thread initiated by Marc Sune months ago.