From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v11 4/5] bond: unit tests
Date: Mon, 30 Jun 2014 10:56:56 +0200
Message-ID: <2202962.L5WHbECMz2@xps13>
References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com>
 <1404064161-26370-5-git-send-email-declan.doherty@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1404064161-26370-5-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Declan,

2014-06-29 18:49, Declan Doherty:
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)
> +SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
> +endif
>  ifeq ($(CONFIG_RTE_APP_TEST),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

I think there is a cleaner way to fix build without bonding.
See my patch proposal below:

 SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
 SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
-SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
 ifeq ($(CONFIG_RTE_APP_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

-- 
Thomas